Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file #5502

Closed
wants to merge 1 commit into from
Closed

ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file #5502

wants to merge 1 commit into from

Conversation

alippai
Copy link
Contributor

@alippai alippai commented Sep 25, 2019 •
edited by andygrove

No description provided.

@alippai alippai force-pushed the patch-2 branch 2 times, most recently from 94f5a02 to dac700b Compare September 26, 2019 07:24
@andygrove
Copy link
Member

@alippai Could you remove the parquet-testing submodule changes from this PR please.

Once the PR against the parquet-testing repo is merged, we can merge this one.

@andygrove andygrove changed the title ARROW-6687: [Rust] Add regression tests for the new datafusion .parqu… ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file Sep 26, 2019
@alippai
Copy link
Contributor Author

alippai commented Sep 26, 2019

@andygrove changed the commit id in the parquet-testing to the merged one. This PR rolls the git submodule "version" (in order to see the changes in parquet-testing).

@codecov-io
Copy link

codecov-io commented Sep 28, 2019 •
edited

Codecov Report

Merging #5502 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5502      +/-   ##
==========================================
+ Coverage   88.66%   89.21%   +0.54%     
==========================================
  Files         965      773     -192     
  Lines      128533   113051   -15482     
  Branches     1501        0    -1501     
==========================================
- Hits       113964   100855   -13109     
+ Misses      14204    12196    -2008     
+ Partials      365        0     -365
Impacted Files Coverage Δ
cpp/src/arrow/json/converter.cc 90.05% <0%> (-1.76%) ⬇️
cpp/src/arrow/json/chunked_builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
cpp/src/arrow/util/thread_pool_test.cc 97.66% <0%> (-0.94%) ⬇️
python/pyarrow/tests/test_parquet.py 95.44% <0%> (-0.12%) ⬇️
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb6b75...136087f. Read the comment docs.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-6687

andygrove
andygrove approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paddyhoran
paddyhoran approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@paddyhoran paddyhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alippai

@asfimport asfimport mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@paddyhoran paddyhoran paddyhoran approved these changes

Assignees
No one assigned
Labels
Component: Parquet Component: Rust - DataFusion Component: Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alippai @andygrove @codecov-io @paddyhoran